Strip trailing newline in markdown code copy#29019
Merged
jolheiser merged 2 commits intogo-gitea:mainfrom Feb 1, 2024
Merged
Conversation
GiteaBot
added
the
lgtm/need 2
silverwind
added
type/enhancement
delvh
approved these changes
Feb 1, 2024
Member
delvh
left a comment
delvh
left a comment
There was a problem hiding this comment.
I can already foresee the future problem Gitea deletes last newline.
But oh well…
GiteaBot
added
lgtm/need 1
jolheiser
approved these changes
Feb 1, 2024
GiteaBot
added
lgtm/done
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Feb 1, 2024
Behaviour now matches GH. Safeguard added in the for loop because `textContent` may be null in which case it does not make sense to render the copy button.
jolheiser
pushed a commit
that referenced
this pull request
Feb 1, 2024
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 2, 2024
* giteaofficial/main: Wrap contained tags and branches again (go-gitea#29021) Avoid sending update/delete release notice when it is draft (go-gitea#29008) Fix incorrect button CSS usages (go-gitea#29015) Strip trailing newline in markdown code copy (go-gitea#29019) Improve user search display name (go-gitea#29002)
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
Behaviour now matches GH. Safeguard added in the for loop because `textContent` may be null in which case it does not make sense to render the copy button.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #29012
Behaviour now matches GH. Safeguard added in the for loop because
textContentmay be null in which case it does not make sense to render the copy button.